Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE-1675: Remove 'Build selectors with appropriate specificity' from … #399

Merged
merged 1 commit into from
Jul 29, 2019
Merged

MQE-1675: Remove 'Build selectors with appropriate specificity' from … #399

merged 1 commit into from
Jul 29, 2019

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Jul 29, 2019 •
edited
Loading

Description

During our fourth team technical guidelines documentation meeting we agreed to remove the "Build selectors with appropriate specificity" tip from the tips and tricks page of devdocs.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@tomreece tomreece requested a review from dobooth July 29, 2019 15:56
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 54.549% when pulling 62bdb2c on MQE-1675 into 3e8ee44 on develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 54.549% when pulling 62bdb2c on MQE-1675 into 3e8ee44 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 54.549% when pulling 62bdb2c on MQE-1675 into 3e8ee44 on develop.

@tomreece tomreece merged commit b6c1e8a into develop Jul 29, 2019
@tomreece tomreece deleted the MQE-1675 branch September 3, 2019 16:32
magento-devops-reposync-svc pushed a commit that referenced this pull request May 9, 2024
@jilu1
Merge pull request #399 from magento-commerce/master-to-develop-1
cc7ad88 
Merging master back to develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobooth dobooth dobooth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @dobooth