-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPUnit missing in dependencies #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lbajsarowicz composer.lock
should be updated also.
@okolesnyk |
@aljcalandra just want to stay compliant with Magento 2 core. Is there any reason to introduce dependency that does not stay in line with core? |
@lbajsarowicz |
@okolesnyk As far as I see you still want to have compatibility with PHP 7.0, but I ran |
@lbajsarowicz And thank you for this PR, it is really make sense to specify PhpUnit dependency. Thank you! |
@okolesnyk Ready. |
Description
Basically in
composer.json
there's a PHPUnit dependency missing, so thatbin/phpunit-checks
is unable to run if phpunit is not installed globally.Contribution checklist