Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Lack of information on API failure (eg. <createEntity>) #544

Closed
lbajsarowicz opened this issue Jan 10, 2020 · 6 comments
Closed

MFTF: Lack of information on API failure (eg. <createEntity>) #544

lbajsarowicz opened this issue Jan 10, 2020 · 6 comments
Labels
acknowledged has-jira-ticket

Comments

@lbajsarowicz
Copy link
Contributor

lbajsarowicz commented Jan 10, 2020 •
edited
Loading

Preconditions

  1. Test that is calling Magento API (eg. AdminVerifyCustomerAddressStateContainValuesOnceTest)

Steps to reproduce

  1. Create required Customer Attribute
  2. Try to run execute any test that creates Customer

Expected result

  1. Test fails with information about error during API Call.

Actual result

  1. image
  2. image
@lbajsarowicz lbajsarowicz changed the title MFTF: Lack of information on API failure (eg. <createData>) MFTF: Lack of information on API failure (eg. <createEntity>) Jan 11, 2020
@lbajsarowicz
Copy link
Contributor Author

My findings: MFTF uses incorrectly the PHPUnit hooks. When _before hook fails, the failure is not being reported. Even then - _after hook is being called.

I'll design the architectural change to address the issue and avoid using hooks, just to let perform rollback of created nodes.

@jilu1
Copy link
Contributor

jilu1 commented Jan 21, 2020

@lbajsarowicz Thank you for reporting this issue!
Have you tested in MFTF release 2.5.4? I think we have a bug fix for a similar issue.

@lbajsarowicz
Copy link
Contributor Author

I tried with the latest 2.4-develop setup of Magento and latest develop branch of MFTF.

@lbajsarowicz lbajsarowicz mentioned this issue Jan 31, 2020
Merged
5 tasks
@lbajsarowicz
Copy link
Contributor Author

I've made the first step - Save Request object even if API call failed.

@soumyau
Copy link
Contributor

soumyau commented Apr 4, 2020

Created JIRA ticket to process this PR: https://jira.corp.magento.com/browse/MQE-2065

okolesnyk added a commit that referenced this issue Apr 17, 2020
@okolesnyk
Merge pull request #567 from lbajsarowicz/bugfix/544-missing-request-…
4f1dd85 
…information

#544 Log Request sent even if Response failed
@jilu1
Copy link
Contributor

jilu1 commented Jul 28, 2020

This feature has been implemented and delivered

@jilu1 jilu1 closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged has-jira-ticket
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lbajsarowicz @soumyau @jilu1