This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
Fix message when maxSaleQty is set and qty is more than maxSaleQty #367
Merged
magento-engcom-team
merged 12 commits into
magento:2.3-develop
from
XxXgeoXxX:2.3-develop#354
Mar 6, 2019
Merged
Fix message when maxSaleQty is set and qty is more than maxSaleQty #367
magento-engcom-team
merged 12 commits into
magento:2.3-develop
from
XxXgeoXxX:2.3-develop#354
Mar 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@XxXgeoXxX Also, need to add one more case to Thanks |
Hi @naydav |
…he "The most you may purchase is %1." message should be sent instead of "Internal server error"
# Conflicts: # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddSimpleProductToCartTest.php
…he "The most you may purchase is %1." message should be sent instead of "Internal server error"
Hi @XxXgeoXxX, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Isuue #354
Description (*)
When maxSaleQty is set and qty is more than maxSaleQty the "The most you may purchase is %1." message should be sent instead of "Internal server error"
Test Execution
Scenario: https://app.hiptest.com/projects/114163/test-plan/folders/801154/scenarios/2692157
Preconditions (*)
Manual testing scenarios (*)
Steps to reproduce (*)
mutation {
addSimpleProductsToCart(
input: {
cart_id: "{{ CART_ID }}",
cartItems: [
{
data: {
sku: "simple-1",
qty: 4
},
}
]
}
) {
cart {
items {
id
qty
product {
sku
name
}
}
}
}
}
Contribution checklist (*)