Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue #453 #627

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Resolved issue #453 #627

merged 4 commits into from
Nov 5, 2019

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 2, 2019

Description

  • Added MFTF test as required by issue
  • Changed css position of the sign in button since the given z-index doesn't affect statically positioned elements

Fixed Issues

Manual testing scenarios

Make sure the ENV file has the following variables

  • ADOBE_STOCK_USER_EMAIL=<adobe_stock_email_id>
  • ADOBE_STOCK_USER_PASSWORD=<adobe_stock_password>
$ vendor/bin/mftf run:test AdminAdobeStockSignedInCreditsVisibleTest --remove

@drpayyne drpayyne requested a review from Nazar65 November 3, 2019 12:44
@drpayyne drpayyne requested a review from eduard13 November 4, 2019 04:59
@sivaschenko sivaschenko added the MFTF tests MFTF tests coverage label Nov 4, 2019
@sivaschenko sivaschenko requested review from hws47a and rogyar November 4, 2019 15:25
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! What does the CSS change do?

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 5, 2019

@filmaj The sign in button already had a z-index property but turns out that, this property doesn't work on statically positioned elements. So I changed the position property from initial to relative to enable to z-index which was already set. This z-index is required for the button to be on top of the profile popup container (which has no content, but overlaps on the signin button) for MFTF tests to simulate a click on the sign in button, else the signin button element is unreachable.

Thank you!

@filmaj filmaj dismissed eduard13’s stale review November 5, 2019 12:30

Changes were addressed.

@filmaj filmaj merged commit 352b994 into magento:develop Nov 5, 2019
@ghost
Copy link

ghost commented Nov 5, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@filmaj
Copy link
Contributor

filmaj commented Nov 5, 2019

Thank you @drpayyne !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants