#450 : [MFTF] User searches for images from the same series as the currently viewed one #543
Conversation
…into 450-mftf-series-filter-test
sivaschenko
force-pushed
the
450-mftf-series-filter-test
branch
from
511dde8 to
0abbf61
Compare
There was a problem hiding this comment.
Hi @konarshankar07 , thanks for the pull request! See my review notes.
AdobeStockImageAdminUi/Test/Mftf/Test/AdminAdobeStockSeeMoreSeriesFilterTest.xml
Outdated
Show resolved
Hide resolved
| <grabAttributeFrom selector="{{AdobeStockSection.firstImageId}}" userInput="data-id" | ||
| stepKey="getFilteredId"/> | ||
| <click selector="{{AdobeStockFilterSection.filters}}" stepKey="expandFilters"/> | ||
| <waitForPageLoad stepKey="waitForFiltersOpen"/> | ||
| <actionGroup ref="AssertIsNotVisibleAdobeStockFilterElementActionGroup" stepKey="checkSerieIdFilter"> | ||
| <argument name="filterName" value="Serie Id"/> | ||
| </actionGroup> | ||
| <click selector="{{AdobeStockFilterSection.cancelFilters}}" stepKey="cancelFilters"/> |
There was a problem hiding this comment.
I don't think this section is necessary for the test. The test should assume the grid is in vanilla state and no filters are applied.
Returning the grid to initial state is a responsibility of after action groups - see resetAdminDataGridToDefaultView
There was a problem hiding this comment.
Hello @sivaschenko ,
I added this section to confirm that serie id filter is not visible in the filter section. If you still want to remove then its fine.
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
…r expanding filters
| <click selector="{{AdobeStockFilterSection.filters}}" stepKey="expandFilters"/> | ||
| <waitForPageLoad stepKey="waitForFiltersOpen"/> |
There was a problem hiding this comment.
It's better to use AdminAdobeStockExpandFiltersActionGroup instead of this two lines
| </actionGroup> | ||
| <click selector="{{AdobeStockFilterSection.cancelFilters}}" stepKey="cancelFilters"/> | ||
| <actionGroup ref="AdminAdobeStockExpandImagePreviewActionGroup" stepKey="expandImagePreview"/> | ||
| <actionGroup ref="AdminAdobeStockApplySameSeriesFilter" stepKey="applySerieFilter"/> |
There was a problem hiding this comment.
Action group name should have ActionGroup suffix, otherwise the exception is thrown during generation:
In TestGenerator.php line 245:
Could not find ActionGroup by ref "AdminAdobeStockApplySameSeriesFilterActionGroup"
in Test "AdminAdobeStockSeeMoreSeriesFilterTest"
AdobeStockImageAdminUi/Test/Mftf/Test/AdminAdobeStockSeeMoreSeriesFilterTest.xml
|
Hi @konarshankar07, thank you for your contribution! |
Description (*)
This PR is regarding MFTF testing for the series filter which is not visible in the Adobe grid
Fixed Issues (if relevant)