Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1620: Not possible to enter multi-line image Description #1624

Conversation

joweecaquicla
Copy link

@joweecaquicla joweecaquicla commented Jul 21, 2020

Description (*)

This PR will fix the issue wherein it is not possible to enter multi-line image description by clicking Enter.

Fixed Issues (if relevant)

  1. Fixes magento/adobe-stock-integration Not possible to enter multi-line image Description  #1620: Not possible to enter multi-line image Description
  2. ...

Manual testing scenarios (*)

  1. Go to Content - Media Gallery
  2. Select an image from Media Gallery, click on "three dots"
  3. Select Edit
  4. Place the cursor to the Description field
  5. Type any text, and hit Enter key
  6. The cursor should go to the next line.

@joweecaquicla joweecaquicla linked an issue Jul 21, 2020 that may be closed by this pull request
@joweecaquicla
Copy link
Author

@magento run all tests

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @joweecaquicla ! Can you please check if the fix from https://github.com/magento/adobe-stock-integration/pull/1597/files can be applied in a different way to avoid reintroducing the issue

@gabrieldagama gabrieldagama added Priority: P2 Should be fixed as early as possible and removed Priority: P2 Should be fixed as early as possible labels Jul 21, 2020
@m2-community-project m2-community-project bot removed the Priority: P2 Should be fixed as early as possible label Jul 21, 2020
@chalov-anton
Copy link
Contributor

Hello @joweecaquicla

Great job on the enter key behavior. The cursor is moved to the next line on Description field and Saves image on Title field.
Tab key, switches from Title field to Description field
Peek 2020-07-22 12-55

❌ The only thing is that, for some reason, a multiline Description. doesn't pass the validation
Selection_044

Do you think you can fix this in the scope of this PR?
Thank you

@joweecaquicla
Copy link
Author

joweecaquicla commented Jul 22, 2020

Hi @chalov-anton!
This PR contains the fix for that issue and it is not yet merged: https://github.com/magento/adobe-stock-integration/pull/1608/files#diff-060e6b3ecbee55b57138dce139ced6f8

@chalov-anton
Copy link
Contributor

Thank you, I'm moving this PR to Ready for Delivery

@ghost
Copy link

ghost commented Jul 22, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to enter multi-line image Description
4 participants