-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1620: Not possible to enter multi-line image Description #1624
#1620: Not possible to enter multi-line image Description #1624
Conversation
…moved keypress event on description field
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request @joweecaquicla ! Can you please check if the fix from https://github.com/magento/adobe-stock-integration/pull/1597/files can be applied in a different way to avoid reintroducing the issue
Hello @joweecaquicla Great job on the enter key behavior. The cursor is moved to the next line on Description field and Saves image on Title field. ❌ The only thing is that, for some reason, a multiline Description. doesn't pass the validation Do you think you can fix this in the scope of this PR? |
Hi @chalov-anton! |
Thank you, I'm moving this PR to Ready for Delivery |
Hi @joweecaquicla, thank you for your contribution! |
Description (*)
This PR will fix the issue wherein it is not possible to enter multi-line image description by clicking Enter.
Fixed Issues (if relevant)
Manual testing scenarios (*)