[MFTF] Cover Used In Media Gallery filter with MFTF #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magento run all tests |
|
@magento run all tests |
sivaschenko
requested changes
Jul 9, 2020
There was a problem hiding this comment.
Thanks for the PR @Nazar65 , please take a look at my comments
| @@ -13,5 +13,8 @@ | |||
| <element name="applyFilters" type="button" selector="//div[@class='media-gallery-container']//button[@data-action='grid-filter-apply']"/> | |||
| <element name="activeFilter" type="text" selector="//div[@class='media-gallery-container']//div[@class='admin__current-filters-list-wrap']//span[contains( ., '{{filter}}')]" parameterized="true"/> | |||
| <element name="activeFilterPlaceholder" type="text" selector="//div[@class='media-gallery-container']//div[@class='admin__current-filters-list-wrap']"/> | |||
| <element name="usedInSelectDropdown" type="text" selector="//div[@class='admin__action-multiselect-text' and text()='Select...']"/> | |||
There was a problem hiding this comment.
The selectors should be more specific, we are going to have more than one multiselect in the filters section
| <actionGroup ref="AdminOpenMediaGalleryTinyMce4ActionGroup" stepKey="openMediaGalleryFromWysiwygToFilterIMage"/> | ||
|
|
||
| <actionGroup ref="AdminEnhancedMediaGalleryExpandFilterActionGroup" stepKey="expandFilters"/> | ||
| <actionGroup ref="AdminMediaGalleryApplyUsedInFIlterActionGroup" stepKey="applyUsedInCategoryFilter"> |
There was a problem hiding this comment.
Suggested change
| <actionGroup ref="AdminMediaGalleryApplyUsedInFIlterActionGroup" stepKey="applyUsedInCategoryFilter"> | |
| <actionGroup ref="AdminMediaGalleryApplyUsedInFilterActionGroup" stepKey="applyUsedInCategoryFilter"> |
|
@magento run all tests |
|
Hi @sivaschenko thanks for the review, done ✔️ |
sivaschenko
approved these changes
Jul 12, 2020
|
Hi @Nazar65, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
functional tests are green