Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Page Builder dependency #1186

Merged
merged 22 commits into from
Apr 22, 2020
Merged

Remove Page Builder dependency #1186

merged 22 commits into from
Apr 22, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Apr 10, 2020

Related Pull Requests

magento/magento2-page-builder#450
magento/magento2#27566

Description (*)

This PR removes dependency between PageBuilder and MediaGallery
PageBuilder after merge magento/magento2-page-builder#450 PB will use default Magento config, and anyone will be able to replace it

Fixed Issues (if relevant)

  1. Remove Page Builder dependency #1180: Remove Page Builder dependency
  2. ...

Manual testing scenarios (*)

Verify that Page Builder opens New Media Gallery without plugin

orlangur
orlangur previously approved these changes Apr 10, 2020
Copy link

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests failures does not seem to be related to changes introduced as to me.

@sivaschenko sivaschenko changed the title Remove Page Builder dependency [WIP] Remove Page Builder dependency Apr 14, 2020
@Nazar65 Nazar65 changed the title [WIP] Remove Page Builder dependency Remove Page Builder dependency Apr 14, 2020
@lenaorobei lenaorobei linked an issue Apr 14, 2020 that may be closed by this pull request
@lenaorobei lenaorobei added this to the 1.1.0 milestone Apr 14, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Apr 15, 2020

integration tests will be passed after merge magento/magento2#27863

lenaorobei
lenaorobei previously approved these changes Apr 15, 2020
@engcom-Golf
Copy link
Contributor

@magento run all tests

@engcom-Golf
Copy link
Contributor

@magento run all tests

lenaorobei
lenaorobei previously approved these changes Apr 16, 2020
@engcom-Golf
Copy link
Contributor

@magento run all tests

@ghost
Copy link

ghost commented Apr 22, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants