Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"More from this model" image preview section #397

Closed
sivaschenko opened this issue Aug 30, 2019 · 2 comments
Closed

"More from this model" image preview section #397

sivaschenko opened this issue Aug 30, 2019 · 2 comments
Labels
Backend Frontend/UI
Milestone
Phase 2: License ...

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Aug 30, 2019 •
edited
Loading

Story

#324 [Story 30] User sees images with the same model as the currently viewed one

Preconditions

  1. Install Magento with Adobe Stock Integration
  2. Configure the integration in Stores -> Configuration -> System -> Adobe Stock Integration fieldset

Steps to reproduce

  1. Login to admin panel
  2. Open Magento Media Gallery (i.e. go to Cms -> Pages, edit the page and insert image)
  3. Click "Search Adobe Stock" button to open images grid
  4. Click on any image

Expected result

Image preview is expanded, "More from this model" section with the same series images is displayed (possible to switch tabs between "More from this series" and "More from this model")

image

Technical Details

  • Update configuratioin of \Magento\AdobeStockClient\Model\SearchParametersProvider\SimpleFilters to introduce the search_parameters[model_id] request parameter
  • I think \Magento\AdobeStockImageAdminUi\Controller\Adminhtml\Preview\Series controller can be reused to load same model images as well (do reduce number of requests to server)
@sivaschenko sivaschenko added this to the Phase 2: License Images milestone Aug 30, 2019
@konarshankar07 konarshankar07 self-assigned this Aug 31, 2019
@konarshankar07 konarshankar07 removed their assignment Aug 31, 2019
@konarshankar07
Copy link
Contributor

@sivaschenko ,
Sorry, I mistakenly assign to me can you please put back in ready for development.
Thanks

@konarshankar07 konarshankar07 self-assigned this Aug 31, 2019
@konarshankar07
Copy link
Contributor

konarshankar07 commented Aug 31, 2019 •
edited
Loading

Please ignore the above comment. I'll start working on this ticket
Thanks

@konarshankar07 konarshankar07 mentioned this issue Sep 1, 2019
Merged
sivaschenko added a commit that referenced this issue Sep 23, 2019
@sivaschenko
Merge pull request #408 from konarshankar07/397-more-from-this-model
7bcf165 
#397 : "More from this model" image preview section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backend Frontend/UI
Projects
None yet
Milestone
Phase 2: License Images
Development

No branches or pull requests
2 participants
@sivaschenko @konarshankar07