Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SaveAssetsKeywordsInterface to delete obsolete keywords #1391

Closed
sivaschenko opened this issue May 26, 2020 · 3 comments · Fixed by magento/magento2#29207
Closed

SaveAssetsKeywordsInterface to delete obsolete keywords #1391

sivaschenko opened this issue May 26, 2020 · 3 comments · Fixed by magento/magento2#29207
Assignees
@jmonteros422
Labels
Backend Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented May 26, 2020 •
edited
Loading

Story

#724

Description

This change should be done in magento2 repo

The functionality of \Magento\MediaGallery\Model\ResourceModel\Keyword\SaveAssetsKeywords::execute should be update to delete the links to the keywords that are not provided in the argument

Testing

\Magento\MediaGallery\Model\ResourceModel\AssetKeywordsTest integration test should be adjusted to cover this case
@sivaschenko sivaschenko added this to the 2.1.0 - Part 1 milestone May 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 26, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@ProkopovVitaliy
Copy link
Contributor

@magento I am working on this

@sivaschenko sivaschenko added the Priority: P1 Needs to be fixed before any other issues label Jun 5, 2020
@lenaorobei
Copy link
Contributor

Hi @ProkopovVitaliy. Do you have any progress with this task? If you need an assistance please let us know.

@sivaschenko sivaschenko added the Severity: S1 Affects critical data or functionality and forces users to employ a workaround label Jul 7, 2020
@Nazar65 Nazar65 self-assigned this Jul 14, 2020
@Nazar65 Nazar65 removed their assignment Jul 14, 2020
@jmonteros422 jmonteros422 self-assigned this Jul 15, 2020
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 16, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
a3e9fea 
…delete obsolete keywords - Add method to delete keywords which has no relation to assets
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 17, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
7c2511a 
…delete obsolete keywords - Revised behaviour to delete obsolete asset keyword link based on updated arguments
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 20, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
d81d262 
…delete obsolete keywords - Move and improve logic for saving and deleting obsolete asset keyword links
@jmonteros422 jmonteros422 mentioned this issue Jul 20, 2020
Merged
4 tasks
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 20, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
fe0be1d 
…delete obsolete keywords - Code enhancement for SavedAssetLinks logic and updated AssetKeywordsTest
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 21, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
659071c 
…delete obsolete keywords - integration test refactor
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 21, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
b166cf5 
…delete obsolete keywords - Enhancements, Revision on integration test and fix unit test failure
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 22, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
cc4c5d0 
…delete obsolete keywords - Revised try catch to resolve failure in unit tests
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Jul 22, 2020
@jmonteros422
magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to …
958fee3 
…delete obsolete keywords - Allow empty keywords to execute saveAssetLinks, added condition to integration test for empty keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmonteros422 jmonteros422

Labels
Backend Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

#1391: SaveAssetsKeywordsInterface to delete obsolete keywords jmonteros422/magento2-1
5 participants
@sivaschenko @Nazar65 @lenaorobei @jmonteros422 @ProkopovVitaliy