chore: grant push_allowances to codeowners for each standard repository #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@sprankhub Any thoughts on this? How can we move forward to get the merge issue resolved? This is an ongoing maintenance pain point. |
|
/plan |
|
@sprankhub Starting Terraform plan https://github.com/mage-os/terraform/actions/runs/10779799728 |
sprankhub
reviewed
Sep 9, 2024
Co-authored-by: Simon Sprankel <[email protected]>
|
@sprankhub Starting Terraform plan https://github.com/mage-os/terraform/actions/runs/10779799728 |
Terraform Plan
|
Closed
|
It looks like this PR changes the permissions as expected. The question now is only: Are these permissions what we want? The teams we give push allowances still shouldn't be able to push to branches directly. They should only be allowed to merge PRs. I'll try to test this when time allows. |
|
Based on my testing I documented in #91 (comment), I think we can merge this as it does what we want. |
sprankhub
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration: currently codeowners can't merge pull requests. My theory is this is caused by the
push_allowanceschange for monorepo setups last month.If that's true, in theory this might fix it by granting
push_allowancesto any codeowners for each repository.I believe the syntax is valid, but the logic is untested, so I'm opening this as a draft. Do with it what you will.