Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for MS.AAD.5.4 - GroupConsent #629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update for MS.AAD.5.4 - GroupConsent #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions powershell/public/cisa/entra/Test-MtCisaAppGroupOwnerConsent.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ function Test-MtCisaAppGroupOwnerConsent {
return $null
}

if ( $SettingsApiAvailable -notcontains 'EnableGroupSpecificConsent' ) {
Add-MtTestResultDetail -SkippedBecause 'Custom' -SkippedCustomReason 'Settings value is not available. This may be due to the change that this API is no longer available for recent created tenants.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change "for recent created tenants" to "for recently created tenants." Is a more specific reason not available in the response?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this sentence from Eidsca test's, are we now changing this everywhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should and was just looking got the best place to submit a PR.

return $null
}

#May need update to https://learn.microsoft.com/en-us/graph/api/resources/teamsappsettings?view=graph-rest-1.0
$result = Invoke-MtGraphRequest -RelativeUri "settings" -ApiVersion beta

Expand Down
Loading