forked from tidyverse/tidyverse.org
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits #1
Merged
+94
−56
Merged
Edits #1
Changes from 11 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
8b6d0bd
Space at EOL
krlmlr e25fb07
Sentence
krlmlr a0b9b39
FIXME
krlmlr b90e8af
Shorten
krlmlr 5ac6f6e
Verbose link
krlmlr 14ec2f6
Not dying on this particular hill here
krlmlr b9a277a
Tweak query, let's see
krlmlr 5762c0a
Prune
krlmlr 6aaf953
This works
krlmlr f847736
Tweak narrative
krlmlr c78073f
Choose pivoting as an important op not yet supported
krlmlr 1f898c0
Link style
krlmlr 5a1f22c
aeolus
krlmlr 2b4b421
Help
krlmlr d97b031
Exclude maintainers
krlmlr 4be5ea9
Thanks
krlmlr f344b9f
Link
krlmlr a13315a
Restore narrative
krlmlr ad9825f
Add vignette link
krlmlr a734638
FIXME
krlmlr fc8122d
Date
krlmlr 3211710
Why bother
krlmlr eea955a
Level
krlmlr 4a20ca3
Move
krlmlr f5e4a38
Detail
krlmlr 20dff03
TBC
krlmlr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it potentially confusing since pivoting is tidyr not dplyr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And
nrow()
is base, not dplyr 🙃There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Row names too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to avoid the confusion then? Could we use this to highlight how seamless all of this is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
row names are a characteristic of the data. You cannot use duckplyr with data that have row names or factors.
Now tidyr would be something like the fallbacks needed for select() etc.