Merge pull request #37 from madfish-solutions/fix_rounding

fix accurancy
madfish-solutions · May 27, 2021 · 9ae028e · 9ae028e
2 parents 0a19e4d + d86d9ca
commit 9ae028e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/contracts/partials/MethodDex.ligo b/contracts/partials/MethodDex.ligo
@@ -387,7 +387,10 @@ function invest_liquidity (const p : dex_action; const s : dex_storage; const th
         s := update_reward(s);
 
         (* calculate tokens to be withdrawn *)
-        const tokens_required : nat = shares_purchased * s.token_pool / s.total_supply;
+        var tokens_required : nat := shares_purchased * s.token_pool / s.total_supply;
+        if shares_purchased * s.token_pool > tokens_required * s.total_supply then
+          tokens_required := tokens_required + 1n
+        else skip;
 
         (* ensure *)
         if tokens_required = 0n (* required tokens doesn't exceed max allowed by user *)

diff --git a/contracts/partials/TTMethodDex.ligo b/contracts/partials/TTMethodDex.ligo
@@ -309,7 +309,13 @@ function invest_liquidity (const p : dex_action; const s : dex_storage; const th
 
         (* calculate tokens to be withdrawn *)
         const tokens_a_required : nat = shares_purchased * pair.token_a_pool / pair.total_supply;
+        if shares_purchased * pair.token_a_pool > tokens_a_required * pair.total_supply then
+          tokens_a_required := tokens_a_required + 1n
+        else skip;
         const tokens_b_required : nat = shares_purchased * pair.token_b_pool / pair.total_supply;
+        if shares_purchased * pair.token_b_pool > tokens_b_required * pair.total_supply then
+          tokens_b_required := tokens_b_required + 1n
+        else skip;
 
         (* ensure *)
         if tokens_a_required = 0n  (* providing liquidity won't impact on price *)