Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting references and wandb #578

Merged
merged 12 commits into from
Feb 11, 2025
Merged

Fix setting references and wandb #578

merged 12 commits into from
Feb 11, 2025

Conversation

dbobrenko
Copy link
Collaborator

@dbobrenko dbobrenko commented Feb 10, 2025 •
edited
Loading

Changes

  • Fix wrong settings object reference everywhere across project;
  • Fix double wandb initialization;
  • Add proper names for wandb runs.

@dbobrenko dbobrenko self-assigned this Feb 10, 2025
@dbobrenko dbobrenko changed the title Fix setting initialization and wandb Fix setting references and wandb Feb 10, 2025
@bkb2135 bkb2135 merged commit 8eb5b7b into staging Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkb2135 bkb2135 bkb2135 approved these changes

Assignees

@dbobrenko dbobrenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbobrenko @bkb2135 @richwardle