Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'SharedSettings' object has no attribute 'INFERENCE_TIMEOUT' #567

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

0xxfu
Copy link
Contributor

@0xxfu 0xxfu commented Feb 6, 2025

  1. SharedSettings has no INFERENCE_TIMEOUT
    https://wandb.ai/macrocosmos/prompting-validators/runs/nmr0ouu1/logs
image 2. fields of website should be optional none https://wandb.ai/macrocosmos/prompting-validators/runs/gagp9cou/logs image

Copy link
Collaborator

@dbobrenko dbobrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @0xxfu !
From the first glance looks good, with a minor request to name parameter accordingly

@dbobrenko dbobrenko changed the base branch from staging to hotfix/SN1-398-inference-web February 6, 2025 09:30
Copy link
Collaborator

@dbobrenko dbobrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbobrenko dbobrenko merged commit 25b8168 into macrocosm-os:hotfix/SN1-398-inference-web Feb 6, 2025
@dbobrenko dbobrenko changed the title fix: AttributeError: 'SharedSettings' object has no attribute 'INFERENCE_TIMEOUT' AttributeError: 'SharedSettings' object has no attribute 'INFERENCE_TIMEOUT' Feb 6, 2025
dbobrenko pushed a commit that referenced this pull request Feb 8, 2025
…IMEOUT' (#567)

1. SharedSettings has no INFERENCE_TIMEOUT
2. Fields of website should be optional none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants