Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves validator code into prompting package #215

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

p-ferreira
Copy link
Contributor

This PR moves the validator init code into the prompting package. This facilitates the code to be accessed within the prompting package scope, making in it easy to integrate with pip install @git/prompting (useful for applications built on top of prompting code).

@bkb2135
Copy link
Collaborator

bkb2135 commented Apr 23, 2024

Does this mean that miners will have to build environments to support the entire validator code? I know that currently they have to anyway, but will this make decoupling the requirements impossible in the future?

@p-ferreira
Copy link
Contributor Author

Does this mean that miners will have to build environments to support the entire validator code? I know that currently they have to anyway, but will this make decoupling the requirements impossible in the future?

This change means that all the code from the validator class is packaged alongside all the remaining code of the validators, which should be ok considering that validators shouldn’t have dependencies out of the requirements scope.

Now talking about the miners, I do believe that custom miners get accompanied with custom requirements, where they could reference the prompting repo itself as one requirement of their suite, so it's still decoupled in the same fashion we are decoupled from bittensor.

@bkb2135 bkb2135 merged commit 40f97d8 into staging Apr 30, 2024
2 checks passed
@p-ferreira p-ferreira mentioned this pull request May 1, 2024
@Hollyqui Hollyqui deleted the features/move-validator-into-prompting branch August 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants