change timing logs from dendrite process_time to be timeout #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffencruz
approved these changes
Apr 3, 2024
steffencruz
requested changes
Apr 3, 2024
| self.uids = uids | ||
| self.completions = [synapse.completion for synapse in responses] | ||
| self.timings = [synapse.dendrite.process_time or 0 for synapse in responses] | ||
| self.timings = [ | ||
| synapse.dendrite.process_time or timeout for synapse in responses |
There was a problem hiding this comment.
this isn't right. needs to consider the status code.
There was a problem hiding this comment.
there are many possible causes for synapse.dendrite.process_time=0. we need more explicit logic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.