Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black staging #144

Merged
merged 3 commits into from
Mar 7, 2024
Merged

black staging #144

merged 3 commits into from
Mar 7, 2024

Conversation

mccrindlebrian
Copy link
Contributor

black entire repo

@mccrindlebrian mccrindlebrian changed the title black entire repo black staging Mar 6, 2024
Copy link
Contributor

@p-ferreira p-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this should be merged into main ASAP, as long as this PR lives staging will be super noisy

Copy link
Contributor

@p-ferreira p-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe those changes should be merged into pre-staging, not sure if it's the best idea to do a release specific for this in this week, what's your thoughts @mccrindlebrian @steffencruz ?

@mccrindlebrian
Copy link
Contributor Author

@p-ferreira We have already merged a black PR into pre-staging, so this is just additional to reduce headache

@steffencruz steffencruz requested a review from p-ferreira March 7, 2024 21:41
@steffencruz steffencruz merged commit 60464bb into staging Mar 7, 2024
3 checks passed
@mccrindlebrian mccrindlebrian deleted the hotfix/black-staging branch April 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants