-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/vllm-base-pipeline #138
Conversation
LGTM. I do have a request that this should be merging into pre-staging, and that the changes for reworking the locations of miners should be included here. This will simplify things greatly when moving this work into streaming |
Also just remember to remove the name main lines and replace with proper tests. |
The main lines there serve as support of maintenance for the file, so it can be easily instantiated + simple example of how to use it. Regarding the tests, they were just added in my last commit. |
I'm not sure if this will be released at the same time than streaming, bringing this up pre-staging could make things more difficult if we plan to release this feature earlier. Let's discuss the release plan for those features, in any case it will be a couple of clicks of work to change this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Looking forward to seeing this go over the finish line soon
Co-authored-by: Steffen Cruz <[email protected]>
…ompting into features/vllm-test
https://wandb.ai/opentensor-dev/alpha-validators/runs/uzvbtwgc?workspace=user-opentensor-pedro