Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/vllm-base-pipeline #138

Merged
merged 32 commits into from
Mar 18, 2024
Merged

Features/vllm-base-pipeline #138

merged 32 commits into from
Mar 18, 2024

Conversation

p-ferreira
Copy link
Contributor

@p-ferreira p-ferreira commented Mar 4, 2024

  • add llm module
  • adds base pipeline
  • adds vllm pipeline and vllm model abstractions
  • replaces zephyr with vllm model
  • adds unit tests

https://wandb.ai/opentensor-dev/alpha-validators/runs/uzvbtwgc?workspace=user-opentensor-pedro

@mccrindlebrian
Copy link
Contributor

LGTM. I do have a request that this should be merging into pre-staging, and that the changes for reworking the locations of miners should be included here. This will simplify things greatly when moving this work into streaming

@mccrindlebrian
Copy link
Contributor

Also just remember to remove the name main lines and replace with proper tests.

@p-ferreira
Copy link
Contributor Author

Also just remember to remove the name main lines and replace with proper tests.

The main lines there serve as support of maintenance for the file, so it can be easily instantiated + simple example of how to use it.

Regarding the tests, they were just added in my last commit.

@p-ferreira
Copy link
Contributor Author

LGTM. I do have a request that this should be merging into pre-staging, and that the changes for reworking the locations of miners should be included here. This will simplify things greatly when moving this work into streaming

I'm not sure if this will be released at the same time than streaming, bringing this up pre-staging could make things more difficult if we plan to release this feature earlier. Let's discuss the release plan for those features, in any case it will be a couple of clicks of work to change this.

Copy link
Collaborator

@steffencruz steffencruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Looking forward to seeing this go over the finish line soon

@p-ferreira p-ferreira merged commit 7e7481c into staging Mar 18, 2024
3 checks passed
@p-ferreira p-ferreira mentioned this pull request Mar 19, 2024
@mccrindlebrian mccrindlebrian deleted the features/vllm-test branch April 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants