Create MinerRegistry and Evaluation Pipelines #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccrindlebrian
changed the title
Sarkosos
reviewed
Jan 27, 2025
|
|
||
| required_files_extensions = ["cpt", "log"] | ||
|
|
||
| self.pdb_location = pdb_location |
There was a problem hiding this comment.
Should move towards class designs that don't change states as we use them? ie, not assigning new class variables in functions, all of them should be defined in the init function etc.
There was a problem hiding this comment.
idea with these evaluators is that we would have many instances of them (one for each miner). But if we don't want to do that, then I agree with you
Sarkosos
reviewed
Jan 27, 2025
folding/rewards/miner_registry.py
Outdated
| for miner_uid in miner_uids: | ||
| self.registry[miner_uid] = {} | ||
| for task in self.tasks: | ||
| self.registry[miner_uid][task] = { |
There was a problem hiding this comment.
Should we make this a pydantic class?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinerRegistryto keep track of generic tasks w/ updates that includes miner credibilities and aggregation functionalitiesEvaluationRegistrythat holds all the eval pipelines for different tasksRewardBaseand reward stacks for different tasks inside of the evaluation registry