-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bali-phy: Update to 3.0.3 #1554
Conversation
Notifying maintainers: |
Travis Build #1906 Passed. Lint results
Port bali-phy success on xcode9.3beta. Log |
Maintainer timed out, so I've merged. Thank you as always, @ryandesign! |
Was I suppose to ack this? merge it? It seemed fine. The next merge is going to require switching to meson, which now works with macports. I will get more involved there. |
We might need some patches and further testing for meson first, but maybe they release a newer version soon. |
My impression was that version 0.45 fixed a lot of problems. If there are still meson issues, I could maybe submit changes to upstream for 0.46. |
See mesonbuild/meson#3356. I didn't test it yet, but I hope it works and we should certainly backport the fix (or switch to a recent git commit) and do more testing with existing and/or new ports. |
Good point. I was wondering if that works as is, since the new generic depfixer is still run under 'if is_elf_platform() and os.path.isfile(outname)', and I thought that os x was not elf. |
Yah, since you're the maintainer, it would have been good if you had acked it. You could also have optionally merged it but someone else would have taken care of that given an ack. |
Ben isn't currently a MacPorts committer so he doesn't have the ability to do that. |
Ah, I misread "contributor" as "member" somehow. My bad. |
Description
Updates the port to 3.0.3 and fixes various problems.
Type(s)
Tested on
macOS 10.12.6 16G1212
Xcode 9.2 9C40b
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?