Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bali-phy: Update to 3.0.3 #1554

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

ryandesign
Copy link
Contributor

Description

Updates the port to 3.0.3 and fixes various problems.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.12.6 16G1212
Xcode 9.2 9C40b

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@bredelings for port bali-phy.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update labels Apr 8, 2018
@macportsbot
Copy link

Travis Build #1906 Passed.

Lint results
--->  Verifying Portfile for bali-phy
--->  0 errors and 0 warnings found.

Port bali-phy success on xcode9.3beta. Log
Port bali-phy success on xcode8.3. Log
Port bali-phy success on xcode7.3. Log

@pmetzger pmetzger merged commit 121eb23 into macports:master Apr 11, 2018
@pmetzger
Copy link
Member

Maintainer timed out, so I've merged. Thank you as always, @ryandesign!

@bredelings
Copy link
Contributor

Was I suppose to ack this? merge it? It seemed fine.

The next merge is going to require switching to meson, which now works with macports. I will get more involved there.

@mojca
Copy link
Member

mojca commented Apr 11, 2018

We might need some patches and further testing for meson first, but maybe they release a newer version soon.

@bredelings
Copy link
Contributor

My impression was that version 0.45 fixed a lot of problems. If there are still meson issues, I could maybe submit changes to upstream for 0.46.

@mojca
Copy link
Member

mojca commented Apr 11, 2018

See mesonbuild/meson#3356. I didn't test it yet, but I hope it works and we should certainly backport the fix (or switch to a recent git commit) and do more testing with existing and/or new ports.

@bredelings
Copy link
Contributor

Good point. I was wondering if that works as is, since the new generic depfixer is still run under 'if is_elf_platform() and os.path.isfile(outname)', and I thought that os x was not elf.

@pmetzger
Copy link
Member

pmetzger commented Apr 11, 2018

@bredelings:

Was I suppose to ack this? merge it? It seemed fine.

Yah, since you're the maintainer, it would have been good if you had acked it. You could also have optionally merged it but someone else would have taken care of that given an ack.

@ryandesign
Copy link
Contributor Author

You could also have optionally merged it

Ben isn't currently a MacPorts committer so he doesn't have the ability to do that.

@ryandesign ryandesign deleted the bali-phy-update branch April 11, 2018 23:41
@pmetzger
Copy link
Member

Ah, I misread "contributor" as "member" somehow. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer: timeout type: update
Development

Successfully merging this pull request may close these issues.

5 participants