Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to V2 Addon #551

Merged
merged 45 commits into from
Feb 4, 2024
Merged

Convert to V2 Addon #551

merged 45 commits into from
Feb 4, 2024

Conversation

machty
Copy link
Owner

@machty machty commented Feb 3, 2024

Notes:

  • Minimum version is 3.28 now after getting rid of macros that were used to preserve pre-tracked computed property infrastructure

babel: {
plugins: [
require.resolve(
'ember-concurrency/babel-plugin-transform-ember-concurrency-async-tasks.js'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a long plugin name!

Thoughts on?:

"ember-concurrency/babel"?

It'd require a a prefix to use without require.resolve, like:

module:ember-concurrency/babel

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, I meant to rename this. Will DM you about module:..., don't know too much about that.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shortened it; seems to work fine with require.resolve:

    babel: {
      plugins: [
        require.resolve('ember-concurrency/async-arrow-task-transform'),
      ],
    },

@machty machty merged commit 15ae406 into master Feb 4, 2024
17 checks passed
@machty machty mentioned this pull request Feb 4, 2024
@machty machty deleted the v2-addon branch February 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants