Fix CI build #537
Merged
Fix CI build #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something (probably a release of new embroider packages) caused most of the floating dependencies scenarios to start failing in all branches. It looks like it was some kind of mismatch between the version of `@embroider/macros` used by `@ember/render-modifiers` (a dependency of `ember-prism`) and whatever version of `@embroider/shared-internals` it was finding in the `node_modules` tree. So this commit updates us to the latest `@embroider/macros`, which allows us to dedupe `@embroider/macros` and `@embroider/shared-internals`, which appears to fix the issue.
|
The |
maxfierke
approved these changes
Jul 22, 2023
lgtm! I'll merge this as long as it's just the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something (probably a release of new embroider packages) caused most of the floating dependencies scenarios to start failing in all branches. It looks like it was some kind of mismatch between the version of
@embroider/macrosused by@ember/render-modifiers(a dependency ofember-prism) and whatever version of@embroider/shared-internalsit was finding in thenode_modulestree.So this commit updates us to the latest
@embroider/macros, which allows us to dedupe@embroider/macrosand@embroider/shared-internals, which appears to fix the issue.