Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design of API-based interface #2

Open
pvh opened this issue Nov 3, 2017 · 0 comments
Open

design of API-based interface #2

pvh opened this issue Nov 3, 2017 · 0 comments

Comments

@pvh
Copy link
Contributor

pvh commented Nov 3, 2017

Okay, so I think what I will do is the following in pgcommitfest2 to support this app:

Phase 1: Commitfest API

Add a simple JSON api that supports querying commitfests, submissions (scoped to a commitfest?), and maybe attachments/patches. Modify the existing app to query those APIs and otherwise behave the same. Release this stuff. (cc/ @mhagander) Can you remind me why you don't look at the commitfest app's attachments? I know you said somewhere but it is lost to me now.

Phase 2: Test Result API

Add a table to pgcommitfest that lets you post back results of your test runs to show up on the submission page, and an API to submit to said table. We might want to have an API key that protects you from submitting bad results and lets us tell who is submitting them... but I don't know that this really matters. What benefit (or even real inconvenience) could rogue submissions have?

Future Work

Improve patch handling.

I haven't got a concrete plan here, but your script based approach is either better or worse than what's in the pgcommitfest app now so either one or the other should be shored up or improved.

Separate Branch Creation from Test Runs

If we can generate canonical-ish git branches (and/or let patch authors submit them via the CF app) we should be able to simplify the mechanism of the app pretty significantly here.

Meta thoughts

If this thing works well, we shouldn't have to enforce standards on the community for patch format. People will be naturally incentivized to post patches in a format that the testing tools will automatically pick up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant