Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README typos and clarify #132

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jul 7, 2022

These changes fix two typos and clarifying language reported by a user.


This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 941

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.282%

Totals Coverage Status
Change from base Build 939: 0.0%
Covered Lines: 1083
Relevant Lines: 1349

💛 - Coveralls

@SaiedKazemi
Copy link
Member

cmd/csvtool/README.md line 6 at r1 (raw file):

tcp-info to more easily usable CSV files. csvtool currently only handles
individual, raw or zstd compressed JSONL files as a source.  Named files should
be the only parameter. If reading uncompressed JSONL from STDIN, provide no

nit: can we use stdin here like it's written elsewhere (and also how typically written)?

@SaiedKazemi
Copy link
Member

:lgtm:

Copy link
Member

@SaiedKazemi SaiedKazemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@stephen-soltesz stephen-soltesz merged commit 9928ad3 into master Jul 7, 2022
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-fix-issues branch August 12, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants