Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oversize msg metric #122

Merged
merged 3 commits into from
Jun 30, 2020
Merged

add oversize msg metric #122

merged 3 commits into from
Jun 30, 2020

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Jun 30, 2020

This adds a metric to allow monitoring when there are netlink messages that are larger than the struct they are being parsed into.
This will allow us to easily detect that the structs need to be updated when the linux kernel returns new data.

This change is Reviewable

@coveralls
Copy link

coveralls commented Jun 30, 2020

Pull Request Test Coverage Report for Build 893

  • 5 of 21 (23.81%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 82.873%

Changes Missing Coverage Covered Lines Changed/Added Lines %
snapshot/snapshot.go 5 21 23.81%
Totals Coverage Status
Change from base Build 886: -0.4%
Covered Lines: 1079
Relevant Lines: 1302

💛 - Coveralls

@gfr10598 gfr10598 requested a review from yachang June 30, 2020 20:27
Copy link

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

Copy link

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@gfr10598 gfr10598 merged commit e966928 into master Jun 30, 2020
@gfr10598 gfr10598 deleted the oversize-msg branch June 30, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants