Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extremely spammy log that stalls parsing #120

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fix extremely spammy log that stalls parsing #120

merged 1 commit into from
Jun 30, 2020

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Jun 30, 2020 •
edited
Loading

When the size log triggers, it logs so much data that it stalls the pipeline.
This reduces output to no more than 1 log per second.

This change is Reviewable

@gfr10598 gfr10598 requested a review from yachang June 30, 2020 15:24
@gfr10598 gfr10598 mentioned this pull request Jun 30, 2020
Closed
yachang
yachang reviewed Jun 30, 2020
View reviewed changes
Copy link

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

yachang
yachang approved these changes Jun 30, 2020
View reviewed changes
Copy link

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@gfr10598 gfr10598 merged commit 737079d into master Jun 30, 2020
@gfr10598 gfr10598 deleted the urgent-fix-spammy-log branch June 30, 2020 15:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 885

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.243%
Changes Missing Coverage Covered Lines Changed/Added Lines %
snapshot/snapshot.go 0 2 0.0%
Totals Coverage Status
Change from base Build 882: 0.0%
Covered Lines: 1078
Relevant Lines: 1295
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yachang yachang yachang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfr10598 @coveralls @yachang