Yet more improvements to auto device detection on boot #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous changes for automatically detecting network and disk devices by various boot script worked fine in sandbox, but failed on mlab4-geg01. These are yet more changes that try to help that process complete successfully.
stephen-soltesz
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
It is straight forward to migrate mlab4-geg01 to the sandbox cluster rather than staging so the dev-debug-cycle can remain in sandbox?
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
nkinkade
commented
Oct 15, 2024
There was a problem hiding this comment.
That's a decent idea. I think it's as straightforward as changing the project in siteinfo, at least that is how the system design is supposed to work. If this doesn't work, then I'll look into trying that.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous changes for automatically detecting network and disk devices by various boot script worked fine in sandbox, but failed on mlab4-geg01. These are yet more changes that try to help that process complete successfully.
If this doesn't work for the staging GEG01 machine, then I may resort to manually building stage3 images for testing, rather than making changes I think will help in sandbox, and which work in sandbox, only to find that they don't, for some reason, work on the GEG01 machine in staging.
This change is