Wait for "forwarded-ip[v6]s" to be available from metadata server before reading value #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race between this script and whatever populates the "forwarded-ip[v6]s" metadata values where sometimes the requests for the values would return 404s, other times not. This adds a loop to be sure the values are populated before continuing.
robertodauria
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this week that in some cases the metadata files /var/local/metadata/external-ip and /var/local/metadata/external-ipv6 container 404 error HTML documents instead of IP addresses. It appears that there is a race between the write-metadata.service running, and when GCP has fully populated the
forwarded-ip[v6]smetadata fields. This PR adds a simple loop to the write-metadata.sh script, but only for the case where the instance is a MIG, since it seems that the other metadata fields are ready by the time write-metadata.sh runs.This PR also adds a small modification to the write-metadata.service unit file, telling it to run before the kubelet.service. Since some of our k8s containers mount the metadata directory and use values within it, we want to be sure that this unit is complete before the kubelet starts and begins to launch containers.
This change is