Add network tags to VMs created by Packer for firewalling #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We lately disabled SSH access to project VMs in most VPCs, notwithstanding the mlab-platform-network. We don't SSH into those nodes, and they don't need to be publicly exposed in that way. However, doing this broke epoxy-images builds for Packer, because, by default, Packer will SSH into the VM that is created using the public address. This commit modifies Packer to omit giving the VM a public address, and to use the private internal address when SSHing into the VM to provision the image. This should work fine for us, since Packer is running in Cloud Build on the same VPC as the VM that is created.
Removes the use_internal_ip and omit_public_ip options, since I did not realize before that Cloud Build instances run in a Google-managed pool of machines outside of project VPCs, so SSHing to the private IP of a VM created by Packer will not work. Instead, this new commit adds a network tag to the VM, which should allow me to create a targeted firewall rule explicitly allowing SSH access to VMs created by Packer.
stephen-soltesz
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lately disabled SSH access to project VMs in most VPCs, notwithstanding the mlab-platform-network. We don't SSH into those nodes, and they don't need to be publicly exposed in that way. However, doing this broke epoxy-images builds for
Packer, because, by default, Packer will SSH into the VM that is created using the public address.
This PR causes Packer to add a special network tag to the VMs it creates, and this tag can be used to create a firewall rule that will explicitly allow public SSH access to VMs it creates, while still disallowing public SSH access to all other VMs.
This change is