Use registration.json format instead of switches.json to get uplink speed #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we are going to support minimal sites with only a single machine and now switch we can no longer reliably get ulink speed information from the switches.json siteinfo format, since minimal sites don't have a switch. This commit changes the source for getting the uplink speed to the registration.json format.
cristinaleonr
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All physical machines have a systemd service that runs on boot which configures the fq qdisc on the default network interface. In order to properly configure the
maxratesetting the script currently relies on the switches.json format. The problem is that not every physical site has a switch any longer, now that the ISC minimal site is moving to production. This PR changes the script to get the sites uplink speed from the registration.json siteinfo format, which will have a record for every machine at every site, no matter whether it is physical, virtual, full or minimal etc.This change is