Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental escape mode for use with client-side katex.js #110

Merged
merged 17 commits into from
Mar 18, 2024

Conversation

rogeryoungh
Copy link
Contributor

@rogeryoungh rogeryoungh commented Mar 11, 2024

fix #109

Copy link
Collaborator

@SichangHe SichangHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice! I provided some design-related suggestions. Please check.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/cfg.rs Outdated Show resolved Hide resolved
src/cfg.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/preprocess.rs Outdated Show resolved Hide resolved
src/render.rs Outdated Show resolved Hide resolved
src/tests/mod.rs Show resolved Hide resolved
README.md Show resolved Hide resolved
src/tests/not_duktape.rs Outdated Show resolved Hide resolved
@SichangHe
Copy link
Collaborator

@rogeryoungh, I made the changes I wanted. Please have a look.

If you don't have any issues, I will squash this into master.

@SichangHe
Copy link
Collaborator

The next step would be to add build instructions and potentially GitHub Action.

@rogeryoungh
Copy link
Contributor Author

The only problem is the readme. When the title is changed to "Escape mode (experimental)", the link should be #escape-mode-experimental.

@rogeryoungh rogeryoungh requested a review from SichangHe March 17, 2024 23:59
@SichangHe SichangHe changed the title Client-side katex.js features Experimental escape mode for use with client-side katex.js Mar 18, 2024
@SichangHe SichangHe merged commit 2d89def into lzanini:master Mar 18, 2024
8 checks passed
@SichangHe
Copy link
Collaborator

🎉 Great work, @rogeryoungh! Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About client-side katex.js features
2 participants