Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .ruby-version file #404

Merged
merged 1 commit into from
Oct 15, 2015

Conversation

xymbol
Copy link
Contributor

@xymbol xymbol commented Oct 12, 2015

If needed, add a sample file or required_ruby_version entry.

If needed, add a sample file or `required_ruby_version` entry.
@booleanbetrayal
Copy link
Collaborator

I don't have strong opinions about this, but seeing as how most gemset managers can parse Gemfile / gemspecs I don't see any harm. One less thing to maintain. =]

booleanbetrayal added a commit that referenced this pull request Oct 15, 2015
@booleanbetrayal booleanbetrayal merged commit 0a31170 into lynndylanhurley:master Oct 15, 2015
@xymbol
Copy link
Contributor Author

xymbol commented Oct 16, 2015

@booleanbetrayal Agree but, it's a common practice to don't have it around.

@lynndylanhurley
Copy link
Owner

@xymbol - If we're going to merge this, can you please add the file to the .gitignore list as well?

@xymbol
Copy link
Contributor Author

xymbol commented Oct 16, 2015

@lynndylanhurley Sorry about that; added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants