Added 'Authorization' header with bearer token #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicolBen
approved these changes
Jun 24, 2022
| @token = DeviseTokenAuth::TokenFactory.new unless @token | ||
| @token.token ||= request.headers[access_token_name] || params[access_token_name] || parsed_auth_cookie[access_token_name] | ||
| @token.client ||= request.headers[client_name] || params[client_name] || parsed_auth_cookie[client_name] | ||
| @token.token ||= request.headers[access_token_name] || params[access_token_name] || parsed_auth_cookie[access_token_name] || decoded_authorization_token[access_token_name] |
There was a problem hiding this comment.
This seems a not breaking way to include authorization header with bearer, great 👏
|
@rhiroshi Could we turn this off when |
|
commented with a different account. I will create a PR this week to address this |
|
@rhiroshi any update on making it possible to disable this header when DeviseTokenAuth.cookie_enabled is true? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Authorization header with bearer token defined in RFC 6750
related issues: #1522 #902 #1487