fix mongoid detecting bug #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicolBen
approved these changes
Apr 28, 2021
|
@MaicolBen Thanks for your approving. |
|
@qiuyin I believe this was a false positive, I don't know how to rerun it, can you rebase/push again? |
qiuyin
force-pushed
the
fix-detect-Mongoid-bug
branch
from
772424e to
419d686
Compare
On rails 6, if change password, in `before_save` callback - `saved_change_to_attribute?(:encrypted_password)` return false - `encrypted_password_changed?` return true
qiuyin
commented
May 9, 2021
| DeviseTokenAuth.remove_tokens_after_password_reset | ||
| else | ||
| saved_change_to_attribute?(:encrypted_password) && |
There was a problem hiding this comment.
saved_change_to_attribute?
- will return false in
before_savecallback - will return true in
after_savecallback
But encrypted_password_changed? is opposite to saved_change_to_attribute?
So we must use encrypted_password_changed?
|
@MaicolBen I have fixed the failed test, Could you review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
This will always return string "expression" even when I don't use Mongoid.