Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign in multiple resources #1248

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

Hamdan85
Copy link
Contributor

@Hamdan85 Hamdan85 commented Jan 8, 2019

shouldn multiple users obey the respective contextual scope?
I think it might help!

@MaicolBen
Copy link
Collaborator

@Hamdan85 can you rebase? there were some travis tests failing that were fixed

@Hamdan85
Copy link
Contributor Author

Hamdan85 commented Jan 12, 2019

@MaicolBen just did. Waiting for the tests to complete.
Glad to help, amazing work!

@MaicolBen
Copy link
Collaborator

@Hamdan85 thanks but you rebased wrong, you pushed #1249 commits, you can try again by cherry picking your commit in a new fresh branch.

@Hamdan85
Copy link
Contributor Author

I'm sorry for that. How about now?

@MaicolBen MaicolBen merged commit 7e4550a into lynndylanhurley:master Jan 15, 2019
@MaicolBen
Copy link
Collaborator

@Hamdan85 perfect! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants