-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required_ruby_version #1208
Add required_ruby_version #1208
Conversation
Because used hash literal that symbol key followed by a colon. The literal is not supported before 2.2.0. Even if it is a version earlier than 2.2.0 you can install it, so when trying to use, raise error.
This gem tested against Lines 7 to 11 in 2413d00
@masatooba what do you think? |
@dks17 This gem can be used if it is 2.1.0 or higher. |
@masatooba |
@dks17 |
@masatooba Yes. I think so. Also we should not forget about @MaicolBen Can we deprecated support for ruby |
@dks17 that isn't a good reason to remove 2.2, I think if we come up with some blocker in code change that 2.2 doesn't allow us, we can remove it. This PR basically doesn't let people install it with 2.1 or lower, right? I'm ok with that |
@MaicolBen Ok. |
@masatooba |
@MaicolBen @dks17 |
Because used hash literal that symbol key followed by a colon.
e.g.
https://github.com/masatooba/devise_token_auth/blob/add-required-ruby-version/lib/devise_token_auth/engine.rb#L41
The literal is not supported before 2.2.0.
Even if it is a version earlier than 2.2.0 you can install it, so when trying to use, raise error.