Add "max" option for strategy #1713
Conversation
| @@ -719,6 +724,14 @@ void MediaStream::setSlideShowMode(bool state) { | |||
| notifyUpdateToHandlers(); | |||
| } | |||
|
|
|||
| void MediaStream::setTargetIsMaxVideoBW(bool state) { | |||
| ELOG_DEBUG("%s targetIsMaxVideoBw: %u", toLog(), state); | |||
| if (target_is_max_video_bw_ == state) { | |||
There was a problem hiding this comment.
Well, we are going to be calling this every time the bw estimation algorithm runs. It's true that, in this particular case, it's an atomic and we're not doing anything else like updating stats. As a result, I'm not sure if this is actually an optimization vs updating the value every time. I somewhat like the pattern but I can be convinced to remove it.
There was a problem hiding this comment.
I doubt that this optimization worths making the function not threadsafe.
| @@ -719,6 +724,14 @@ void MediaStream::setSlideShowMode(bool state) { | |||
| notifyUpdateToHandlers(); | |||
| } | |||
|
|
|||
| void MediaStream::setTargetIsMaxVideoBW(bool state) { | |||
There was a problem hiding this comment.
Consider adding a TODO here to remove this new state once we have a connection maximum bandwidth limit.
There was a problem hiding this comment.
I don't think we would necessarily have to remove this, I think it adds a different option that is helpful when you have connection maximum bandwidth limit
| @@ -732,6 +745,11 @@ uint32_t MediaStream::getTargetVideoBitrate() { | |||
| uint32_t bitrate_from_max_quality_layer = getBitrateFromMaxQualityLayer(); | |||
|
|
|||
| uint32_t target_bitrate = max_bitrate; | |||
|
|
|||
| if (target_is_max_video_bw_) { | |||
There was a problem hiding this comment.
could max_bitrate be 0 because it has not been initialized? Maybe we should return kInitialBitrate in that case, as we do below.
Description
This PR adds a new option in the priority configuration ->
max. This option means that the distributor will always try to assign the definedmaxVideoBWfor that stream. In order to have that work correctly, this PR also adds new functionality: subscribers will, by default, be assigned the maxVideoBW of the publisher. If a different maxVideoBW is assigned directly to the subscription, the minimum between the new maxVideoBW and the publishers' one will be assigned.Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.