Merge apache 5df1fcb

.gitignore

@@ -24,6 +24,7 @@
 .coverage
 .DS_Store
 .eggs
+.envrc
 .idea
 .mypy_cache
 .python-version

.pre-commit-config.yaml

@@ -16,11 +16,21 @@
 #
 repos:
 -   repo: https://github.com/ambv/black
-    rev: stable
+    rev: 19.3b0
     hooks:
     -   id: black
         language_version: python3
 
+-   repo: https://github.com/asottile/seed-isort-config
+    rev: v1.9.3
+    hooks:
+    -   id: seed-isort-config
+
+-   repo: https://github.com/pre-commit/mirrors-isort
+    rev: v4.3.21
+    hooks:
+    -   id: isort
+
 -   repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v2.2.3
     hooks:
@@ -30,8 +40,3 @@ repos:
     -   id: check-added-large-files
     -   id: check-yaml
     -   id: debug-statements
-
--   repo: https://gitlab.com/pycqa/flake8
-    rev: 3.7.1
-    hooks:
-    -   id: flake8

.travis.yml

@@ -75,7 +75,10 @@ jobs:
       env: TOXENV=black
     - language: python
       python: 3.6
-      env: TOXENV=flake8
+      env: TOXENV=isort
+    - language: python
+      python: 3.6
+      env: TOXENV=mypy
     - language: python
       python: 3.6
       env: TOXENV=py36-sqlite

CHANGELOG.md

@@ -18,6 +18,34 @@ under the License.
 -->
 ## Change Log
 
+### 0.34.1 (2019/09/27 18:22 +00:00)
+- [#8271](https://github.com/apache/incubator-superset/pull/8271) Fix: Missing time series datapoints in druid show up as absurd values in line chart (#8271) (@KKcorps)
+- [#8265](https://github.com/apache/incubator-superset/pull/8265) Fixed korean translation error. (#8265) (@kuckjwi0928)
+- [#8223](https://github.com/apache/incubator-superset/pull/8223) Fix sync failed when datasource is schema-less (#8223) (@zhaoyongjie)
+- [#8231](https://github.com/apache/incubator-superset/pull/8231) [SQL Lab] Fix bug when filtering on results that include nulls (#8231) (@etr2460)
+- [#8174](https://github.com/apache/incubator-superset/pull/8174) Bump flask-appbuilder to 2.1.13 (#8174) (@paulvic)
+- [#8176](https://github.com/apache/incubator-superset/pull/8176) Bump FAB to 2.1.13 (#8176) (@dpgaspar)
+- [#8209](https://github.com/apache/incubator-superset/pull/8209) [examples] Fix, sf population polygons div by zero error (#8209) (@dpgaspar)
+- [#8070](https://github.com/apache/incubator-superset/pull/8070) [Explore view] Fix extra data fetch when user clicks Run Query (#8070) (@graceguo-supercat)
+- [#8054](https://github.com/apache/incubator-superset/pull/8054) [sql lab] persist tables list in localStorage (#8054) (@graceguo-supercat)
+- [#8077](https://github.com/apache/incubator-superset/pull/8077) Revert "Fixed Histogram visualization bug.  (#8077)" (#8145) (@etr2460)
+- [#8044](https://github.com/apache/incubator-superset/pull/8044) fix: issues #8041 - bubble support for complex metrics (#8044) (@mistercrunch)
+- [#8126](https://github.com/apache/incubator-superset/pull/8126) adding spaces missing from string concatenations (#8126) (@rusackas)
+- [#8191](https://github.com/apache/incubator-superset/pull/8191) Update core.py (#8191) (@john-bodley)
+- [#7951](https://github.com/apache/incubator-superset/pull/7951) [feat] Add d3 legend formatting for Arc, Polygon and Scatter deck.gl maps (#7951) (@thunter009)
+- [#8181](https://github.com/apache/incubator-superset/pull/8181) [bugfix] Correctly quote table and schema in select_star (#8181) (@villebro)
+- [#8180](https://github.com/apache/incubator-superset/pull/8180) Make orderby native sqla construct (#8180) (@villebro)
+- [#8165](https://github.com/apache/incubator-superset/pull/8165) [bugfix] fix timegrain addon regression (#8165) (@villebro)
+- [#8128](https://github.com/apache/incubator-superset/pull/8128) Add check for calls to cache_key_wrapper (#8128) (@villebro)
+- [#8117](https://github.com/apache/incubator-superset/pull/8117) Fix to Werkzeug ProxyFix; expose ProxyFix configuration items (#8117) (@ericandrewmeadows)
+- [#8117](https://github.com/apache/incubator-superset/pull/8077) Fixed Histogram visualization bug. (#8077) (@kuckjwi0928)
+- [#8052](https://github.com/apache/incubator-superset/pull/8052) Set disableErrorBoundary in SuperChart to fix chart error handling (#8052) (@michellethomas)
+- [#8049](https://github.com/apache/incubator-superset/pull/8049) fix: onSave datasource raises React error (#8049) (@mistercrunch)
+- [#8037](https://github.com/apache/incubator-superset/pull/8037) fix: handle case where result exists but corresponding query cannot be found (#8037) (@serenajiang)
+- [#8025](https://github.com/apache/incubator-superset/pull/8025) [bugfix] Fix deck_polygon metric bug and update examples chart (#8025) (@villebro)
+- [#8014](https://github.com/apache/incubator-superset/pull/8014) [fix] Allow dashboard viewer auto refresh dashboard (#8014) (@graceguo-supercat)
+- [#8013](https://github.com/apache/incubator-superset/pull/8013) Fix: There was an issue fetching the favorite status of this dashboard #6824 (#8013) (@arthurpduarte)
+
 ### 0.34.0 (2019/08/09 00:58 +00:00)
 - [#7997](https://github.com/apache/incubator-superset/pull/7997) Event logger config takes instance instead of class (#7997) (@DiggidyDave)
 - [#8006](https://github.com/apache/incubator-superset/pull/8006) Local config no longer fails to import silently (#8006) (@DiggidyDave)

CONTRIBUTING.md

@@ -24,6 +24,7 @@ little bit helps, and credit will always be given.
 
 ## Table of Contents
 
+- [Orientation](#orientation)
 - [Types of Contributions](#types-of-contributions)
   - [Report Bugs](#report-bugs)
   - [Submit Ideas or Feature Requests](#submit-ideas-or-feature-requests)
@@ -54,6 +55,34 @@ little bit helps, and credit will always be given.
   - [Merging DB migrations](#merging-db-migrations)
   - [SQL Lab Async](#sql-lab-async)
 
+
+## Orientation
+
+Here's a list of repositories that contain Superset-related packages:
+
+- [apache/incubator-superset](https://github.com/apache/incubator-superset)
+  is the main repository containing the `apache-superset` Python package
+  distributed on
+  [pypi](https://pypi.org/project/apache-superset/). This repository
+  also includes Superset's main Javascript bundles and react apps under
+  the [superset/assets](https://github.com/apache/incubator-superset/tree/master/superset/assets)
+  folder.
+- [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui)
+  contains core Superset's
+  [npm packages](https://github.com/apache-superset/superset-ui/tree/master/packages).
+  These packages are shared across the React apps in the main repository,
+  and in visualization plugins.
+- [apache-superset/superset-ui-plugins](https://github.com/apache-superset/superset-ui-plugins)
+  contains the code for the default visualizations that ship with Superset
+  and are maintained by the core community.
+- [apache-superset/superset-ui-plugins-deckgl](https://github.com/apache-superset/superset-ui-plugins-deckgl)
+  contains the code for the geospatial visualizations that ship with Superset
+  and are maintained by the core community.
+- [github.com/apache-superset](https://github.com/apache-superset) is the
+  Github organization under which we manage Superset-related
+  small tools, forks and Superset-related experimental ideas.
+
+
 ## Types of Contributions
 
 ### Report Bug
@@ -80,8 +109,8 @@ For large features or major changes to codebase, please create **Superset Improv
 
 ### Fix Bugs
 
-Look through the GitHub issues. Issues tagged with `#bug` is
-open to whoever wants to implement it.
+Look through the GitHub issues. Issues tagged with `#bug` are
+open to whoever wants to implement them.
 
 ### Implement Features
 
@@ -479,6 +508,24 @@ The Python code is auto-formatted using [Black](https://github.com/python/black)
 is configured as a pre-commit hook. There are also numerous [editor integrations](https://black.readthedocs.io/en/stable/editor_integration.html).
 
 
+## Conventions
+
+### Python
+
+Parameters in the `config.py` (which are accessible via the Flask app.config dictionary) are assummed to always be defined and thus should be accessed directly via,
+
+```python
+blueprints = app.config["BLUEPRINTS"]
+```
+
+rather than,
+
+```python
+blueprints = app.config.get("BLUEPRINTS")
+```
+
+or similar as the later will cause typing issues. The former is of type `List[Callable]` whereas the later is of type `Optional[List[Callable]]`.
+
 ## Testing
 
 ### Python Testing

NOTICE

@@ -1,4 +1,4 @@
-Apache Superset
+Apache Superset (incubating)
 Copyright 2016-2019 The Apache Software Foundation
 
 This product includes software developed at The Apache Software

README.md

@@ -22,8 +22,8 @@ Superset
 [![Build Status](https://travis-ci.org/apache/incubator-superset.svg?branch=master)](https://travis-ci.org/apache/incubator-superset)
 [![PyPI version](https://badge.fury.io/py/apache-superset.svg)](https://badge.fury.io/py/apache-superset)
 [![Coverage Status](https://codecov.io/github/apache/incubator-superset/coverage.svg?branch=master)](https://codecov.io/github/apache/incubator-superset)
-[![PyPI](https://img.shields.io/pypi/pyversions/superset.svg?maxAge=2592000)](https://pypi.python.org/pypi/superset)
-[![Join the chat at https://gitter.im/airbnb/superset](https://badges.gitter.im/apache/incubator-superset.svg)](https://gitter.im/airbnb/superset?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![PyPI](https://img.shields.io/pypi/pyversions/apache-superset.svg?maxAge=2592000)](https://pypi.python.org/pypi/apache-superset)
+[![Get on Slack](https://img.shields.io/badge/slack-join-orange.svg)](https://join.slack.com/t/apache-superset/shared_invite/enQtNDMxMDY5NjM4MDU0LWJmOTcxYjlhZTRhYmEyYTMzOWYxOWEwMjcwZDZiNWRiNDY2NDUwNzcwMDFhNzE1ZmMxZTZlZWY0ZTQ2MzMyNTU)
 [![Documentation](https://img.shields.io/badge/docs-apache.org-blue.svg)](https://superset.incubator.apache.org)
 [![dependencies Status](https://david-dm.org/apache/incubator-superset/status.svg?path=superset/assets)](https://david-dm.org/apache/incubator-superset?path=superset/assets)
 
@@ -130,7 +130,7 @@ Resources
 * [Docker image](https://hub.docker.com/r/amancevice/superset/) (community contributed)
 * [Slides from Strata (March 2016)](https://drive.google.com/open?id=0B5PVE0gzO81oOVJkdF9aNkJMSmM)
 * [Stackoverflow tag](https://stackoverflow.com/questions/tagged/apache-superset)
-* [Join our Slack](https://join.slack.com/t/apache-superset/shared_invite/enQtNDMxMDY5NjM4MDU0LTc2Y2QwYjE4NGYwNzQyZWUwYTExZTdiZDMzMWQwZjc2YmJmM2QyMDkwMGVjZTA4N2I2MzUxZTk2YmE5MWRhZWE)
+* [Join our Slack](https://join.slack.com/t/apache-superset/shared_invite/enQtNDMxMDY5NjM4MDU0LWJmOTcxYjlhZTRhYmEyYTMzOWYxOWEwMjcwZDZiNWRiNDY2NDUwNzcwMDFhNzE1ZmMxZTZlZWY0ZTQ2MzMyNTU)
 * [DEPRECATED Google Group](https://groups.google.com/forum/#!forum/airbnb_superset)
 
 
@@ -162,12 +162,14 @@ the world know they are using Superset. Join our growing community!
  1. [Clark.de](http://clark.de/)
  1. [Cloudsmith](https://cloudsmith.io)
  1. [CnOvit](http://www.cnovit.com/)
+ 1. [Deepomatic](https://deepomatic.com/)
  1. [Dial Once](https://www.dial-once.com/en/)
  1. [Digit Game Studios](https://www.digitgaming.com/)
  1. [Douban](https://www.douban.com/)
  1. [Endress+Hauser](http://www.endress.com/)
- 1. [FBK - ICT center](http://ict.fbk.eu)
  1. [Faasos](http://faasos.com/)
+ 1. [Fanatics](https://www.fanatics.com)
+ 1. [FBK - ICT center](http://ict.fbk.eu)
  1. [Fordeal](http://www.fordeal.com)
  1. [GFG - Global Fashion Group](https://global-fashion-group.com)
  1. [GfK Data Lab](http://datalab.gfk.com)
@@ -176,6 +178,7 @@ the world know they are using Superset. Join our growing community!
  1. [HuiShouBao](http://www.huishoubao.com/)
  1. [Intercom](https://www.intercom.com/)
  1. [jampp](https://jampp.com/)
+ 1. [komoot](https://www.komoot.com/)
  1. [Konfío](http://konfio.mx)
  1. [Kuaishou](https://www.kuaishou.com/)
  1. [Lime](https://www.limebike.com/)
@@ -184,21 +187,23 @@ the world know they are using Superset. Join our growing community!
  1. [Maieutical Labs](https://maieuticallabs.it)
  1. [Myra Labs](http://www.myralabs.com/)
  1. [Now](https://www.now.vn/)
- 1. [PeopleDoc](https://www.people-doc.com)
  1. [Ona](https://ona.io)
+ 1. [PeopleDoc](https://www.people-doc.com)
  1. [Pronto Tools](http://www.prontotools.io)
  1. [QPID Health](http://www.qpidhealth.com/    )
  1. [Qunar](https://www.qunar.com/)
+ 1. [Safaricom](https://www.safaricom.co.ke/)
  1. [Scoot](https://scoot.co/)
  1. [ScopeAI](https://www.getscopeai.com)
  1. [Shopee](https://shopee.sg)
  1. [Shopkick](https://www.shopkick.com)
+ 1. [Showmax](https://tech.showmax.com)
  1. [source{d}](https://www.sourced.tech)
  1. [Steamroot](https://streamroot.io/)
- 1. [Showmax](https://tech.showmax.com)
  1. [Tails.com](https://tails.com)
  1. [Tenable](https://www.tenable.com)
  1. [THE ICONIC](http://theiconic.com.au/)
+ 1. [TME QQMUSIC/WESING](https://www.tencentmusic.com/)
  1. [Tobii](http://www.tobii.com/)
  1. [Tooploox](https://www.tooploox.com/)
  1. [TrustMedis](https://trustmedis.com)
@@ -212,4 +217,3 @@ the world know they are using Superset. Join our growing community!
  1. [Zaihang](http://www.zaih.com/)
  1. [Zalando](https://www.zalando.com)
  1. [Zalora](https://www.zalora.com)
- 1. [TME QQMUSIC/WESING](https://www.tencentmusic.com/)