Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include json files #63

Merged
merged 1 commit into from
Aug 30, 2019
Merged

fix: include json files #63

merged 1 commit into from
Aug 30, 2019

Conversation

khtruong
Copy link

@khtruong khtruong commented Aug 30, 2019

This PR broke us - apache#8109

And this PR has a partial fix - apache#8148

I have included the fix and also added a second line to include package.json as well which I think is needed. We are in discussion with the developer about this. Until then, we will add this fix to unblock us.

@DiggidyDave DiggidyDave merged commit 7e3cf36 into lyft-master Aug 30, 2019
@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #63 into lyft-master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           lyft-master      #63   +/-   ##
============================================
  Coverage        65.04%   65.04%           
============================================
  Files              495      495           
  Lines            23536    23536           
  Branches          2598     2598           
============================================
  Hits             15309    15309           
  Misses            8079     8079           
  Partials           148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c0359...18aef58. Read the comment docs.

@khtruong khtruong mentioned this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants