Moved CommandContext and CommandResult to command package #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Why are we moving this to models? I'm not a fan of that models package because it inevitably becomes a dumping ground. Let's keep data models in meaningful packages. Like in this case, maybe keeping it in a package called command and then the objects could just be Context and Result? Wdyt?
|
I like that, I was moving to models just to get it out of events. I like moving them to |
rename CommandContext -> Context rename CommandResult -> Result
msarvar
changed the title
Aayyush
pushed a commit
that referenced
this pull request
Mar 22, 2022
* Moved CommandContext and CommandResult to models (#193) * Moved CommandContext and CommandResult to models * move from models to command rename CommandContext -> Context rename CommandResult -> Result * moved command related helpers into command package * move ProjectCommandContext and ProjectResult to command/project package * move project command context and project result * revert unrelated code * move tests * fix left over * fix linting * fix tests * remove unused import * fix project context dependencies * fix depenedecies * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new
commandpackage to contain command to contain everything command specific.Moved
CommandContext,CommandResult,CommandLock,CommandName,ProjectCommandContext,ProjectResult, andCommandResultinto the package.Removed
Commandfrom all structs.For instance:
Both
ProjectCommandContextandProjectResultshave a dependency onCommandNameso I had to move them together to avoid cyclical dependencies