Ensure error checks happen before adding results. (#160)

lyft · Nov 19, 2021 · 9fd8043 · 9fd8043
1 parent 8511c35
commit 9fd8043
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/server/events/vcs/github_client.go b/server/events/vcs/github_client.go
@@ -520,12 +520,13 @@ func (g *GithubClient) getRepoChecks(repo models.Repo, sha string) ([]*github.Ch
 		}
 
 		result, response, err := g.client.Checks.ListCheckRunsForRef(g.ctx, repo.Owner, repo.Name, sha, opts)
-		results = append(results, result.CheckRuns...)
 
 		if err != nil {
 			return results, errors.Wrapf(err, "getting check runs for page %d", nextPage)
 		}
 
+		results = append(results, result.CheckRuns...)
+
 		if response.NextPage == 0 {
 			break
 		}