Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: accept exclude components options #17

Merged
merged 1 commit into from
May 15, 2023

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented May 9, 2023

This PR addresses #16.

excludeComponentsFilter is added aside from preset since preset is general while excludeComponentsFilter is project-specific.

@lxsmnsyc
Copy link
Owner

lxsmnsyc commented May 9, 2023

This isn't a scalable atm so I won't go with this kind of filtering. I'm thinking of comment pragmas as an alternative, subtle solution.

@SukkaW
Copy link
Contributor Author

SukkaW commented May 9, 2023

This isn't a scalable atm so I won't go with this kind of filtering. I'm thinking of comment pragmas as an alternative, subtle solution.

Yes. That's why I am creating the PR as a draft. It is just a PoC yet.

@lxsmnsyc
Copy link
Owner

lxsmnsyc commented May 9, 2023

Yes. That's why I am creating the PR as a draft. It is just a PoC yet.

maybe we can do

/* @forgetti skip */
function MyComponent() {

}

@SukkaW SukkaW force-pushed the exclude-component branch from 46fb7dc to b525224 Compare May 10, 2023 12:50
@SukkaW SukkaW changed the base branch from main to next May 11, 2023 04:03
@SukkaW
Copy link
Contributor Author

SukkaW commented May 11, 2023

Yes. That's why I am creating the PR as a draft. It is just a PoC yet.

maybe we can do

/* @forgetti skip */
function MyComponent() {

}

Done in 1d5bcdb (#17). I have also rebased the PR to target the next branch, too.

@SukkaW SukkaW marked this pull request as ready for review May 11, 2023 04:03
@lxsmnsyc
Copy link
Owner

What's the status on this? I can include this in 0.5.0

@SukkaW
Copy link
Contributor Author

SukkaW commented May 15, 2023

What's the status on this? I can include this in 0.5.0

I will start rebasing this to the next branch now.

@lxsmnsyc I have rebased the PR to the latest next branch. You can review this now.

@SukkaW SukkaW force-pushed the exclude-component branch from 1d5bcdb to 2d48c6d Compare May 15, 2023 13:32
@lxsmnsyc lxsmnsyc merged commit fcba375 into lxsmnsyc:next May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants