Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colons support in RGB definition #78

Closed
XVilka opened this issue Aug 30, 2014 · 4 comments · Fixed by lxqt/qtermwidget#284
Closed

Colons support in RGB definition #78

XVilka opened this issue Aug 30, 2014 · 4 comments · Fixed by lxqt/qtermwidget#284
Labels
feature requests

Comments

@XVilka
Copy link

XVilka commented Aug 30, 2014

Here's a test case:

printf "\x1b[38:2:255:100:0mTRUECOLOR\x1b[0m\n"

Keep in mind that it is possible to use both ';' and ':' as parameters delimiter.

More info about that (mostly links for the various terminals, console applications and true colour support)
@pvanek pvanek mentioned this issue Sep 1, 2014
Closed
@pvanek
Copy link
Contributor

pvanek commented Sep 1, 2014

@XVilka can you point me to konsole sources where is it handled, please? For me it's quite low priority as I don't see any real use for it. But if it's in konsole it can be quite easily ported to qtermwidget as it's konsole based originally.

@pvanek
Copy link
Contributor

pvanek commented Sep 1, 2014

reference: https://gist.github.com/XVilka/8346728

@XVilka
Copy link
Author

XVilka commented Sep 1, 2014

@pvanek it should be in src/V102Emulation.cpp

@XVilka XVilka mentioned this issue Feb 12, 2015
Closed
@XVilka XVilka mentioned this issue Mar 4, 2015
Closed
@XVilka XVilka mentioned this issue Nov 15, 2016
Open
This was referenced Jan 7, 2017
Closed
Closed
@XVilka XVilka mentioned this issue Apr 19, 2017
Open
@XVilka XVilka mentioned this issue Sep 15, 2017
Open
@XVilka XVilka mentioned this issue Nov 10, 2017
Open
@XVilka XVilka mentioned this issue Feb 16, 2018
Closed
@XVilka XVilka mentioned this issue May 11, 2018
Open
@XVilka XVilka mentioned this issue Dec 13, 2018
Closed
@yan12125 yan12125 mentioned this issue Jun 2, 2019
Closed
@yan12125 yan12125 mentioned this issue Jul 7, 2019
Merged
yan12125 pushed a commit to lxqt/qtermwidget that referenced this issue Jul 7, 2019
Colons support in RGB definition
759c27d 
With this patch, non-color sequences using colons are also accepted. I
consider such sequences undefined behavior, though.

 Closes lxqt/qterminal#78
yan12125 pushed a commit to lxqt/qtermwidget that referenced this issue Jul 7, 2019
Colons support in RGB definition
53817e9 
With this patch, non-color sequences using colons are also accepted. I
consider such sequences undefined behavior, though.

Closes lxqt/qterminal#78
@yan12125 yan12125 mentioned this issue Jul 7, 2019
Merged
agaida pushed a commit to lxqt/qtermwidget that referenced this issue Jul 15, 2019
@agaida
Colons support in RGB definition
0d9c8cf 
With this patch, non-color sequences using colons are also accepted. I
consider such sequences undefined behavior, though.

Closes lxqt/qterminal#78
@XVilka XVilka mentioned this issue Jul 19, 2019
Closed
zettdaymond pushed a commit to zettdaymond/qterminal that referenced this issue Sep 7, 2019
@agaida
Merge pull request lxqt#78 from f2404/patch-1
4b0662d 
Fix building instructions
semiscone pushed a commit to semiscone/qtermwidget that referenced this issue Jul 14, 2020
@semiscone
Colons support in RGB definition
e307d2b 
With this patch, non-color sequences using colons are also accepted. I
consider such sequences undefined behavior, though.

Closes lxqt/qterminal#78
@hyiltiz
Copy link

hyiltiz commented Mar 4, 2022

It is possible for qterminal to always set COLORTERM=truecolor? https://gist.github.com/XVilka/8346728 suggests it should be set by the supporting terminals, and using helix-editor, when I do :set theme<TAB>onedark<ENTER>, it complains "no true color support". But starting it inside qterminal with COLORTERM=truecolor hx has no such problem.

@XVilka XVilka mentioned this issue Jul 28, 2022
Open
inventor2525 pushed a commit to inventor2525/qtermwidget that referenced this issue May 14, 2024
@agaida
Colons support in RGB definition
37335fc 
With this patch, non-color sequences using colons are also accepted. I
consider such sequences undefined behavior, though.

Closes lxqt/qterminal#78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Colons support in RGB definition lxqt/qtermwidget
3 participants
@XVilka @pvanek @hyiltiz