Error on compile on Fedora Rawhide

[farchord]

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

1. Compile obconf-qt on Fedora Rawhide

Context

This issue stops us from compiling obconf-qt on the next version of Fedora (Rawhide).

System Information

• Distribution & Version: Fedora 40 (Rawhide)
• Kernel: 6.8.0-0.rc0.20240110gitab27740f7665
• Qt Version: 5.15.12
• libqtxdg Version: 3.12.0
• lxqt-build-tools Version: 0.13.0
• Package version: 0.16.3

The short of the error is as follows:

/builddir/build/BUILD/obconf-qt-0.16.3/src/obconf-qt.cpp:233:36: error: invalid conversion from ‘const xmlError*’ {aka ‘const _xmlError*’} to ‘xmlErrorPtr’ {aka ‘_xmlError*’} [-fpermissive]
233 | xmlErrorPtr e = xmlGetLastError();
| ~~~~~~~~~~~~~~~^~
| |
| const xmlError* {aka const _xmlError*}

Attaching the whole build log as well.

Thank you!
build.log

[tsujan]

Does replacing the line

obconf-qt/src/obconf-qt.cpp

Line 233 in d4f36e2

xmlErrorPtr e = xmlGetLastError();

with

const xmlError *e = xmlGetLastError();

fix the problem? I can't test because I'm on Wayland.

[stefonarch]

I get the same error now on arch, the patch resolves it.
Why should wayland matter for compile btw?

[tsujan]

Why should wayland matter for compile btw?

Not for compilation but for running and testing — at least here, it crashes on Wayland.

EDIT:
If the app really works with that change, I could make a point release.

[stefonarch]

at least here, it crashes on Wayland.

Ok, but here it opens fine with QT_QPA_PLATFORM=xcb obconf-qt and looks working, changed theme to test.

EDIT: will run x11 session with openbox to be sure.

[tsujan]

@stefonarch
Thanks for testing! I'm in the middle of some work but will make another point release tonight or tomorrow after making the change. Is that OK with you? Do you want to merge #219 or any translation?

@farchord
Thanks for reporting!

[stefonarch]

Obconf-qt is working fine I see, go ahead. There are no new translations, but some have been merged after the last release, nothing to merge.

[tsujan]

nothing to merge.

What about #219?

[stefonarch]

I've lost interest somehow in this, as it's not possible for most lxqt apps.