-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config option to disable title capitalization #408
Conversation
Users can set disableTitleCapitalization to true in order to, well, disable title capitalization. Fixes lxndrblz#368
👷 Deploy Preview for anatole-demo processing.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@ericswpark Thanks for your PR. I wonder if that's really sufficient |
@lxndrblz it really is a rough draft I wrote on my phone so I may have (read: probably will have) missed a ton. In addition this PR doesn't affect any CSS rules, as noted in the original issue report. I opted not to include it because a) I don't know how to disable CSS rules based on Hugo configuration, and b) we still need to figure out whether to have it configurable in one configuration option or in a separate one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericswpark LGTM. Thanks for your PR.
Quality Gate passedIssues Measures |
Today I updated my blog to v1.15 and the new options work like a charm, thank you very much! |
Description
Users can set disableTitleCapitalization to true in order to, well, disable title capitalization.
Issue Number
Fixes #368
Additional Information (Optional)
I wrote this on my phone so it may not work?
Checklist
Yes, I included all necessary artefacts, including:
Documentation moved to wiki since I last contributed here, so once this PR is merged I guess the wiki could be edited?
Testing Checklist
Yes, I ensured that all of the following scenarios were tested:
Notify the following users