Skip to content

Commit

Permalink
fix: remove mixin to fix print layout (#391)
Browse files Browse the repository at this point in the history
Removes the desktop_and_print mixin as it resulted in broken print layout.
  • Loading branch information
Sohn123 authored Mar 26, 2023
1 parent 86586db commit 7981438
Show file tree
Hide file tree
Showing 22 changed files with 33 additions and 35 deletions.
10 changes: 0 additions & 10 deletions assets/scss/modules/_config.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,6 @@
}
}

@mixin desktop_and_print {
@include desktop {
@content;
}

@include print {
@content;
}
}

@mixin ltr {
@if $text-direction == ltr {
@content;
Expand Down
4 changes: 2 additions & 2 deletions assets/scss/partials/components/_footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
&__sidebar {
display: none;

@include desktop_and_print {
@include desktop {
display: inline-block;
}
}

&__base {
@include desktop_and_print {
@include desktop {
display: none;
}
}
Expand Down
16 changes: 8 additions & 8 deletions assets/scss/partials/components/_portfolio.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
padding-bottom: 0px;
padding-top: 48px;

@include desktop_and_print {
@include desktop {
padding: 48px;
}

Expand All @@ -19,7 +19,7 @@
background: transparent;
border-radius: 0.5em;

@include desktop_and_print {
@include desktop {
@include themed() {
border: t('border');
}
Expand Down Expand Up @@ -62,7 +62,7 @@
background-color: t('accent');
}

@include desktop_and_print {
@include desktop {
width: 60%;
object-fit: contain;
max-width: none;
Expand All @@ -72,14 +72,14 @@
}

&--left {
@include desktop_and_print {
@include desktop {
margin-right: auto;
margin-left: 0;
}
}

&--right {
@include desktop_and_print {
@include desktop {
margin-right: 0;
margin-left: auto;
}
Expand All @@ -95,7 +95,7 @@
background-color: t('accent');
}

@include desktop_and_print {
@include desktop {
padding: 48px;
border-radius: 0.5em;

Expand All @@ -112,7 +112,7 @@
border-bottom: t('border');
}

@include desktop_and_print {
@include desktop {
@include themed() {
background: t('primary-lighter');
}
Expand All @@ -123,7 +123,7 @@
}

&--right {
@include desktop_and_print {
@include desktop {
margin-left: auto;
}
}
Expand Down
4 changes: 2 additions & 2 deletions assets/scss/partials/components/_sidebar.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.sidebar {
margin-top: 40px;

@include desktop_and_print {
@include desktop {
z-index: 2;
position: fixed;
height: 100%;
Expand All @@ -24,7 +24,7 @@
}

&__content {
@include desktop_and_print {
@include desktop {
display: flex;
flex-direction: column;
flex-grow: 1;
Expand Down
6 changes: 3 additions & 3 deletions assets/scss/partials/components/_wrapper.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
&__main {
width: 100%;

@include desktop_and_print {
@include desktop {
width: $content-width;
}

Expand All @@ -24,7 +24,7 @@
&--fullscreen {
margin-top: 20px;

@include desktop_and_print {
@include desktop {
width: 100%;
margin-top: 0px;
}
Expand All @@ -39,7 +39,7 @@
width: 100%;
padding: 16px 0;

@include desktop_and_print {
@include desktop {
width: $sidebar-width;
padding: 0;
}
Expand Down
4 changes: 2 additions & 2 deletions assets/scss/partials/layout/_nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

display: none;

@include desktop_and_print {
@include desktop {
display: flex;
justify-content: space-between;
align-items: center;
Expand All @@ -20,7 +20,7 @@
background-color: t('primary-lighter');
}

@include desktop_and_print {
@include desktop {
display: flex;
padding: $py-desktop 30px;

Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"Target":"scss/main.rtl.min.afb781d764f2b83b63ec6dd90788a35093c19a6a1ec9f8a2252b9cd3c4f01084.css","MediaType":"text/css","Data":{"Integrity":"sha256-r7eB12TyuDtj7G3ZB4ijUJPBmmoeyfiiJSuc08TwEIQ="}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"Target":"scss/main.rtl.min.a5eecfb30c244001796ebc324fb94c5c70ec99f77efddd26487bb075c44eb931.css","MediaType":"text/css","Data":{"Integrity":"sha256-pe7PswwkQAF5brwyT7lMXHDsmfd+/d0mSHuwdcROuTE="}}
{"Target":"scss/main.rtl.min.2729eba917180e5aafe266bae3afdc453fae08a509853c392ea0d0a086d98424.css","MediaType":"text/css","Data":{"Integrity":"sha256-JynrqRcYDlqv4ma646/cRT+uCKUJhTw5LqDQoIbZhCQ="}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"Target":"scss/main.min.afcf7a74c48633d6afc6447bf52d6af2c1bbc24b0cb0ce6d834cc98f49bfba77.css","MediaType":"text/css","Data":{"Integrity":"sha256-r896dMSGM9avxkR79S1q8sG7wksMsM5tg0zJj0m/unc="}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"Target":"scss/main.min.5794be192d21535bdd301561e043a96b6adbad2b5c08279deff459e4661c613f.css","MediaType":"text/css","Data":{"Integrity":"sha256-V5S+GS0hU1vdMBVh4EOpa2rbrStcCCed7/RZ5GYcYT8="}}
{"Target":"scss/main.min.b8b237b391418778d0814b850b954825076f5ebbc0da1d1530c888e654ddcf4b.css","MediaType":"text/css","Data":{"Integrity":"sha256-uLI3s5FBh3jQgUuFC5VIJQdvXrvA2h0VMMiI5lTdz0s="}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"Target":"scss/main.rtl.min.afb781d764f2b83b63ec6dd90788a35093c19a6a1ec9f8a2252b9cd3c4f01084.css","MediaType":"text/css","Data":{"Integrity":"sha256-r7eB12TyuDtj7G3ZB4ijUJPBmmoeyfiiJSuc08TwEIQ="}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"Target":"scss/main.rtl.min.a5eecfb30c244001796ebc324fb94c5c70ec99f77efddd26487bb075c44eb931.css","MediaType":"text/css","Data":{"Integrity":"sha256-pe7PswwkQAF5brwyT7lMXHDsmfd+/d0mSHuwdcROuTE="}}
{"Target":"scss/main.rtl.min.2729eba917180e5aafe266bae3afdc453fae08a509853c392ea0d0a086d98424.css","MediaType":"text/css","Data":{"Integrity":"sha256-JynrqRcYDlqv4ma646/cRT+uCKUJhTw5LqDQoIbZhCQ="}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"Target":"scss/main.min.afcf7a74c48633d6afc6447bf52d6af2c1bbc24b0cb0ce6d834cc98f49bfba77.css","MediaType":"text/css","Data":{"Integrity":"sha256-r896dMSGM9avxkR79S1q8sG7wksMsM5tg0zJj0m/unc="}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"Target":"scss/main.min.5794be192d21535bdd301561e043a96b6adbad2b5c08279deff459e4661c613f.css","MediaType":"text/css","Data":{"Integrity":"sha256-V5S+GS0hU1vdMBVh4EOpa2rbrStcCCed7/RZ5GYcYT8="}}
{"Target":"scss/main.min.b8b237b391418778d0814b850b954825076f5ebbc0da1d1530c888e654ddcf4b.css","MediaType":"text/css","Data":{"Integrity":"sha256-uLI3s5FBh3jQgUuFC5VIJQdvXrvA2h0VMMiI5lTdz0s="}}

0 comments on commit 7981438

Please sign in to comment.