Makefile: allow forcing kernel module build or skip #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, whether to build the QUIC kernel modules was determined automatically by checking if /lib/modules/$(uname -r)/kernel/net/quic existed, assuming the module was already built into the kernel. This patch introduces a --with/without-modules configure option to let users explicitly control module building: --with-modules or --with-modules=yes: force building the modules --without-modules or --with-modules=no: skip building the modules If this option is not provided, the build system will continue to detect module presence automatically using the existing logic. Note: If QUIC is already built into the kernel, the system uses the existing header file at /usr/include/linux/quic.h to build libquic, and skips installing a duplicate copy in libquic/Makefile.am. Additionally, fix the workaround in tests/interop/Dockerfile. Signed-off-by: Xin Long <[email protected]>
|
Thanks! It seems to work. However I guess it would also be useful to only build and install the module without the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, whether to build the QUIC kernel modules was determined automatically by checking if /lib/modules/$(uname -r)/kernel/net/quic existed, assuming the module was already built into the kernel.
This patch introduces a --with/without-modules configure option to let users explicitly control module building:
--with-modules or --with-modules=yes: force building the modules
--without-modules or --with-modules=no: skip building the modules
If this option is not provided, the build system will continue to detect module presence automatically using the existing logic.
Note: If QUIC is already built into the kernel, the system uses the existing header file at /usr/include/linux/quic.h to build libquic, and skips installing a duplicate copy in libquic/Makefile.am.
Additionally, fix the workaround in tests/interop/Dockerfile.